Fix native code generation of empty libraries on MSVC #2829
+112
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Oct 31, 2019
|
What about linker_can_create_empty_archives?
Done. This pr is now ready
…On Oct 31, 2019, 5:07 PM +0900, Jérémie Dimino ***@***.***>, wrote:
@diml requested changes on this pull request.
In src/dune/lib_config.mli:
> @@ -16,3 +16,5 @@ type t =
val allowed_in_enabled_if : string list
val get_for_enabled_if : t -> var:string -> string
+
+val emit_empty_archives : t -> bool
The name is clear enough in the context of this PR, but I feel like it wouldn't immediately be obvious what it means to a new reader. What about linker_can_create_empty_archives?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
rgrinberg
force-pushed
the
empty-archive-info
branch
from
d1593cf to
b62b450
Compare
Otherwise, the string argument is unclear. Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg
force-pushed
the
empty-archive-info
branch
from
b62b450 to
6740b1c
Compare
These cannot be produced with msvc Signed-off-by: Rudi Grinberg <[email protected]>
rgrinberg
force-pushed
the
empty-archive-info
branch
from
6740b1c to
bddaddf
Compare
This was referenced Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-make of #2693. It depends #2828 to be merged first. At which point
I will implement
Lib_config.empty_native_archivecorrectly.